Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveshare edits #14

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Liveshare edits #14

merged 4 commits into from
Oct 31, 2024

Conversation

benrich37
Copy link
Owner

Edits made during liveshare with Matt (removing some of commented out code, making docustring language more clear)

  • changed back one line I forgot to fix in "electronic_structure" property for ElementBase from when I was trying to remove redundancy between Species and ElementBase

@benrich37 benrich37 merged commit 2b93194 into master Oct 31, 2024
3 checks passed
@benrich37 benrich37 deleted the liveshare branch October 31, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant