Cleanup #18
Merged
Cleanup #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivate) + removing commented out code
…ileslice as its only foreseeable utility is in its initializing a jdftxoutfileslice object
…s its only foreseeable utility is in its initializing a joutstructure object. "is_lowdin_start_line" not included due to usage in other class initializations. Moving "get_joutstructures_start_idx" and "get_joutstructure_step_bounds" to joutructures module.
…ll pprint and to extend repr to incorporate properties for JDFTXOutfileSlice (but not for deeper objects). This behavior is far from good, but is at least better than it was. This can be fixed later once the usage for stringify is more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding explicit str methods, moving JDFTXInfile and JDFTXOutfile classes to the inputs and outputs modules (will be moved to own modules once broader input/output classes are written