Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks #2

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Minor tweaks #2

merged 4 commits into from
Sep 25, 2024

Conversation

benrich37
Copy link
Owner

  • Coverage now at 97%
  • Small error-handling tweaks
  • "ion" tag now rejects species names it doesn't recognize, and JDFTXStructure will fix incorrectly grabbed "specie" labels in get_str method (previously would return something like "Si1" by accident)

…trospect I think defining __setitem__ explicitly was a misstep and should've been a public set_tag method, but changing it breaks a lot of tests so that is now a whole task. I think enough new code has been written here that my coverage may actually drop
…ng methods since they are never reached by the current code design.
@benrich37 benrich37 merged commit e22fd8e into master Sep 25, 2024
3 checks passed
benrich37 pushed a commit that referenced this pull request Jan 13, 2025
fixed cartesian coords in from_jdftxinfile method and added Etot to p…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant