Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input/output utils testing separation #35

Merged
merged 1 commit into from
Nov 21, 2024
Merged

input/output utils testing separation #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/io/jdftx/test_input_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from __future__ import annotations

import pytest

from pymatgen.io.jdftx._input_utils import flatten_list


def test_flatten_list():
assert flatten_list("", [1, 2, 3]) == [1, 2, 3]
assert flatten_list("", [1, [2, 3]]) == [1, 2, 3]
assert flatten_list("", [1, [2, [3]]]) == [1, 2, 3]
assert flatten_list("", [1, [2, [3, [4]]]]) == [1, 2, 3, 4]
with pytest.raises(TypeError):
flatten_list("", 1)
10 changes: 0 additions & 10 deletions tests/io/jdftx/test_utils.py → tests/io/jdftx/test_output_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,10 @@

import pytest

from pymatgen.io.jdftx._input_utils import flatten_list
from pymatgen.io.jdftx._output_utils import find_first_range_key, get_start_lines, multi_getattr, multi_hasattr
from pymatgen.io.jdftx.joutstructures import _get_joutstructures_start_idx


def test_flatten_list():
assert flatten_list("", [1, 2, 3]) == [1, 2, 3]
assert flatten_list("", [1, [2, 3]]) == [1, 2, 3]
assert flatten_list("", [1, [2, [3]]]) == [1, 2, 3]
assert flatten_list("", [1, [2, [3, [4]]]]) == [1, 2, 3, 4]
with pytest.raises(TypeError):
flatten_list("", 1)


def test_get_start_lines():
with pytest.raises(ValueError, match="Outfile parser fed an empty file."):
get_start_lines([])
Expand Down