Skip to content

Commit

Permalink
fix: PROXY_VALIDATE_SSL = False by default on Neo4j proxy (amundsen-i…
Browse files Browse the repository at this point in the history
…o#142)

* PROXY_ENCRYPTED = False by default on Neo4j proxy

* Update

* Update
  • Loading branch information
jinhyukchang authored Jun 10, 2020
1 parent fe3335e commit 3c0149c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion metadata_service/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ class Config:

PROXY_USER = os.environ.get('CREDENTIALS_PROXY_USER', 'neo4j')
PROXY_PASSWORD = os.environ.get('CREDENTIALS_PROXY_PASSWORD', 'test')

PROXY_ENCRYPTED = True
"""Whether the connection to the proxy should use SSL/TLS encryption."""
PROXY_VALIDATE_SSL = True

# Prior to enable PROXY_VALIDATE_SSL, you need to configure SSL.
# https://neo4j.com/docs/operations-manual/current/security/ssl-framework/
PROXY_VALIDATE_SSL = False
"""Whether the SSL/TLS certificate presented by the user should be validated against the system's trusted CAs."""

IS_STATSD_ON = False
Expand Down
2 changes: 1 addition & 1 deletion metadata_service/proxy/neo4j_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def __init__(self, *,
password: str = '',
num_conns: int = 50,
max_connection_lifetime_sec: int = 100,
encrypted: bool = True,
encrypted: bool = False,
validate_ssl: bool = False) -> None:
"""
There's currently no request timeout from client side where server
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from setuptools import setup, find_packages

__version__ = '2.5.2'
__version__ = '2.5.3'


requirements_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'requirements.txt')
Expand Down

0 comments on commit 3c0149c

Please sign in to comment.