Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing a block to advisory_lock in tests #1587

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Fix passing a block to advisory_lock in tests #1587

merged 1 commit into from
Jan 26, 2025

Conversation

Earlopain
Copy link
Collaborator

This method does not take a block. As such, the expectation is never executed

@Earlopain
Fix passing a block to advisory_lock in tests
4757d0b 
This method does not take a block. As such, the expectation is never executed
@bensheldon
Copy link
Owner

Thanks for catching that!

@bensheldon bensheldon added the refactor Code changes that do not introduce new features label Jan 26, 2025
@bensheldon bensheldon merged commit 348fc1d into bensheldon:main Jan 26, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Code changes that do not introduce new features
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Earlopain @bensheldon