New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformers): support `trust_remote_code` and added unit tests #4271

Merged

MingLiangDai merged 7 commits into bentoml:main from MingLiangDai:transformers-import-tests

Nov 28, 2023

Contributor

MingLiangDai commented Nov 9, 2023

What does this PR address?

Add unit tests to transformers import model

Before submitting:

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

MingLiangDai self-assigned this

MingLiangDai requested a review from a team as a code owner

November 9, 2023 21:49

MingLiangDai requested review from aarnphm and removed request for a team

November 9, 2023 21:49

aarnphm reviewed

View reviewed changes

Contributor

aarnphm left a comment

Actually how to do we import a trust_remote_code=True model? Sth like chatglm or baichuan

tests/integration/frameworks/test_transformers_unit.py Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Outdated Show resolved Hide resolved

src/bentoml/_internal/frameworks/transformers.py Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Outdated Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Outdated Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Outdated Show resolved Hide resolved

aarnphm requested changes

View reviewed changes

Contributor

aarnphm left a comment

Final comments, then GTG

src/bentoml/_internal/frameworks/transformers.py Show resolved Hide resolved

src/bentoml/_internal/frameworks/transformers.py Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Outdated Show resolved Hide resolved

aarnphm reviewed

View reviewed changes

src/bentoml/_internal/frameworks/transformers.py Outdated Show resolved Hide resolved

aarnphm changed the title ~~transformers import model unit tests~~ fix(transformers): support trust_remote_code and added unit tests

MingLiangDai and others added 7 commits

November 27, 2023 21:27


          transformers import model tests

a22f7bb


          accomodate for trust_remote_code

304e45c


          address PR comments

fc03062


          remove irrelevant logs

1f32dc0


          add reference to issue opened in accelerate

0188c3f


          Update src/bentoml/_internal/frameworks/transformers.py

9d9b03c

Co-authored-by: Aaron Pham <[email protected]>


          Update transformers.py

bd29780

MingLiangDai force-pushed the transformers-import-tests branch from ad26fa9 to bd29780 Compare

November 28, 2023 02:28

aarnphm approved these changes

View reviewed changes

MingLiangDai merged commit 2929789 into bentoml:main

This was referenced Dec 22, 2023

feat: support .python-version symlink #4354

Merged

fix(with_config): annotate return type #4355

Merged

chore(generated): new stubs for proto 4 #4374

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet