fix: use Alternative when Buffer not available like CF #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest updating to min node 18 as it's the one in maintenance. |
riderx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow fixing the bug I have in production env where I deploy on Cloudflare workers, as documented here:
https://developers.cloudflare.com/workers/runtime-apis/nodejs/buffer/
We cannot use Buffer without explicit import.
The problem is: This lib builds for deprecated Nodejs versions 12 and 14 who don't have the explicit import yet.
So I created a function who can use Buffer or btoa if available.
This makes the lib fully portable. As we already use Cross fetch