Refactor the onStartCommand method to use switch statement for action…

… handling and improve readability.
bepass-org · Jun 15, 2024 · f8b4ea1 · f8b4ea1
1 parent 9e764c3
commit f8b4ea1
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/app/src/main/java/org/bepass/oblivion/OblivionVpnService.java b/app/src/main/java/org/bepass/oblivion/OblivionVpnService.java
@@ -365,16 +365,18 @@ public synchronized int onStartCommand(Intent intent, int flags, int startId) {
             return START_NOT_STICKY;
         }
 
-        if (action.equals(FLAG_VPN_START)) {
-            start();
-            return START_STICKY;
-        }
+        switch (action) {
+            case FLAG_VPN_START:
+                start();
+                return START_STICKY;
 
-        if (action.equals(FLAG_VPN_STOP)) {
-            onRevoke();
-            return START_NOT_STICKY;
+            case FLAG_VPN_STOP:
+                onRevoke();
+                return START_NOT_STICKY;
+
+            default:
+                return START_NOT_STICKY;
         }
-        return START_NOT_STICKY;
     }
 
     @Override