Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VpnService improvements #58

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

ameerhossein
Copy link
Contributor

Made some improvements to the connection state handling. Current connection state was being published to every registered observer whenever a new observer was being registered due to an oversight.

Created a base activity that observes connection state. This is done to prevent service binding logic duplication in every single activity.

@ameerhossein ameerhossein mentioned this pull request Feb 21, 2024
@markpash markpash self-requested a review February 21, 2024 19:39
Copy link
Member

@markpash markpash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me. I'll merge this and hopefully run some tests.
I'll also probably enable CI builds on push to the main branch so we can see where builds fail. And the apk should get uploaded so we can play with what's currently on main.

@markpash markpash merged commit 92a9c74 into bepass-org:main Feb 21, 2024
@ameerhossein ameerhossein deleted the vpn-service-improvements branch February 22, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants