Missing XComponent.dispose calls in screenshot tests

Change-Id: I5df25a16303719593d40f08d1e7c15e4636a2d02
beppec56 · Nov 18, 2016 · 14af38f · 14af38f
1 parent 0da4cde
commit 14af38f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/sc/qa/unit/screenshots/screenshots.cxx b/sc/qa/unit/screenshots/screenshots.cxx
@@ -282,6 +282,9 @@ void ScScreenshotTest::testOpeningModalDialogs()
 
     /// process input file containing the UXMLDescriptions of the dialogs to dump
     processDialogBatchFile("sc/qa/unit/screenshots/data/screenshots.txt");
+
+    mxComponent->dispose();
+    mxComponent.clear();
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(ScScreenshotTest);

diff --git a/sd/qa/unit/dialogs-test.cxx b/sd/qa/unit/dialogs-test.cxx
@@ -101,6 +101,8 @@ class SdDialogsTest : public ScreenshotTest
 
     virtual void setUp() override;
 
+    void tearDown() override;
+
     // try to open a dialog
     void openAnyDialog();
 
@@ -138,6 +140,11 @@ void SdDialogsTest::setUp()
     CPPUNIT_ASSERT(mpImpressDocument);
 }
 
+void SdDialogsTest::tearDown()
+{
+    mxComponent->dispose();
+    ScreenshotTest::tearDown();
+}
 
 SdAbstractDialogFactory* SdDialogsTest::getSdAbstractDialogFactory()
 {

diff --git a/sw/qa/unit/sw-dialogs-test.cxx b/sw/qa/unit/sw-dialogs-test.cxx
@@ -43,6 +43,8 @@ class SwDialogsTest : public ScreenshotTest
 
     void setUp() override;
 
+    void tearDown() override;
+
     // try to open a dialog
     void openAnyDialog();
 
@@ -78,6 +80,12 @@ void SwDialogsTest::setUp()
     (*fn)();
 }
 
+void SwDialogsTest::tearDown()
+{
+    component_->dispose();
+    ScreenshotTest::tearDown();
+}
+
 void SwDialogsTest::registerKnownDialogsByID(mapType& /*rKnownDialogs*/)
 {
     // fill map of known dialogs