[WIP] Adding wormhole streamer modules #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good .. recommend a warning assertion that can be disabled when words are not injected consecutively into network. How in the progress on de-BPifying? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental wormhole streamer modules which are protocol-agnostic helpers to funnel wormhole links to a regular ready/valid header+data protocol. These are used to great effect in BlackParrot along with https://github.com/black-parrot/black-parrot/blob/master/bp_me/src/v/network/bp_me_wormhole_header_encode.sv to inject protocol-specific information. Refactoring and clarification to come before ready for review
Necro: #232