Fix warning about signed->unsigned conversion #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.58% // Head: 88.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #161 +/- ##
========================================
Coverage 88.58% 88.58%
========================================
Files 32 32
Lines 3618 3619 +1
Branches 690 690
========================================
+ Hits 3205 3206 +1
Misses 228 228
Partials 185 185
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Don't mind! LGTM! |
|
@moinakb001 Thanks. What compiler/version were you seeing these warnings with? |
|
GCC version 11.3.0 compiled with -march=znver3 and -D__AVX__ |
Closed
|
Fixed in release v4.4.31. |
solardiz
referenced
this pull request
Nov 18, 2022
In 894aee7 we introduced some changes, which show is this error when building with GCC v12.2.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160 didn't fix the sign truncation warning, the wrong set of tests were run. Sorry for the churn, this actually fixes the issue.