Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to footer #340

Closed
tuxmea opened this issue Mar 25, 2024 · 5 comments · Fixed by #353
Closed

Add version to footer #340

tuxmea opened this issue Mar 25, 2024 · 5 comments · Fixed by #353
Assignees
Labels
enhancement New feature or request

Comments

@tuxmea
Copy link
Member

tuxmea commented Mar 25, 2024

When opening the HDM webpage I would like to see which version is used.
Version should be based on the GIT Tag or read from a file.

@tuxmea tuxmea added the enhancement New feature or request label Mar 25, 2024
@tuxmea
Copy link
Member Author

tuxmea commented Mar 25, 2024

@rwaffen @bastelfreak Feedback from your side?

@oneiros
Copy link
Collaborator

oneiros commented Mar 25, 2024

I remember we discussed setting a VERSION constant inside of a rails inititalizer (something like config/inititalizers/version.rb). This is evaluated once on startup. At this point we could simply shell out to git to try to get a version number.

But I wonder, do we always have a git command and a git repo? Even in docker?

@oneiros
Copy link
Collaborator

oneiros commented Apr 11, 2024

But I wonder, do we always have a git command and a git repo? Even in docker?

The answer is "yes" 🙂:

hdm/Dockerfile

Line 16 in c576292

git \

@rwaffen
Copy link
Member

rwaffen commented Apr 11, 2024

we added git some time ago when we had this idea with the seperated git repository to write back data and not change it in the local data dir.

@rwaffen
Copy link
Member

rwaffen commented Apr 11, 2024

@tuxmea its nice to have, so that you know exactly what is installed/used

rwaffen added a commit that referenced this issue Apr 11, 2024
Show version number in footer #340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants