Fix and consolidate check for chrome.runtime.lastError #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
Dec 18, 2020
src/js/tabs/logging.js
Outdated
| @@ -102,6 +102,11 @@ TABS.logging.initialize = function (callback) { | |||
| ConfigStorage.get('logging_file_entry', function (result) { | |||
| if (result.logging_file_entry) { | |||
| chrome.fileSystem.restoreEntry(result.logging_file_entry, function (entry) { | |||
| if (chrome.runtime.lastError) { | |||
| console.error(chrome.runtime.lastError.message); | |||
There was a problem hiding this comment.
What happens if you just do console.error(chrome.runtime.lastError)? NW.js should be smart enough to dump the error message and stack trace in this case.
There was a problem hiding this comment.
This prints Object instead of the message property. Caller or Callee properties are not accessible in strict mode.
Was looking for a utility or common file to put this kind of stuff to de-deduplicate like in serial.js but then with an extra line:
console.log((new Error).stack);
haslinghuis
force-pushed
the
fix-chrome-errors
branch
4 times, most recently
from
46e32c0 to
ca537df
Compare
haslinghuis
changed the title
haslinghuis
force-pushed
the
fix-chrome-errors
branch
from
ca537df to
431aa6b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mikeller
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2350utils/common.jsfor common used functions likecheckChromeRuntimeError()and changed codebase to use this function.Fixes: #2350