Support of FlySky NV 14 added #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
Jun 23, 2019
src/SCRIPTS/BF/ui.lua
Outdated
| @@ -313,9 +313,9 @@ function run_ui(event) | |||
| elseif currentState == pageStatus.displayMenu then | |||
| if event == userEvent.release.exit then | |||
| currentState = pageStatus.display | |||
| elseif event == userEvent.release.plus or event == userEvent.dial.left then | |||
| elseif event == userEvent.release.plus or event == userEvent.dial.right then | |||
There was a problem hiding this comment.
These changes will cause the rotary wheel to work backwards for other TX with a rotary wheel. If the NV14's rotary wheel is mounted backwards then this has to be worked around in a different way (and should probably be fixed in OpenTX, and not in these lua scripts).
There was a problem hiding this comment.
Changes reverted as requested.
mikeller
approved these changes
Jun 25, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for NV14 added.
Please let me know if my change of events is correct - in my opinion plus is corresponding to right cursor movement. For navigation in NV14 currently we are using trim joysticks in following configuration:
Left:
-Up- Menu
-Down - Telemetry
-Left - PgDwn
-Right - PgUp
-Click - Exit
Right:
-Up - Plus
-Down -Minus
-Left - Rotary left
-Right - Rotary right
-Click - Enter
In next version maybe I will be able to implement touch events.