Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup improvements #389

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

klutvott123
Copy link
Member

Some improvements to the popup menu and the confirmation page functionality.

The popup menu can now be opened by long pressing enter on the main menu and on the page view. The menu is now created on demand so that we can populate it with different items depending on the uiState we're in.

Now we can do this:
screenshot_x7_21-05-09_21-17-41

and this:
screenshot_x7_21-05-09_21-17-52

Made a new state uiStatus.confirm for the confirmation dialogue.
Added a confirmation dialogue for downloading vtx tables too.
screenshot_x7_21-05-09_21-38-58

Changed the behaviour a little so that after calibrating the accelerometer or downloading vtx tables the script will return to the previous uiState on completion. This just makes the user experience a little nicer. The old behaviour was that it returned to the main menu.

Removed getSensorValue and simplified modelActive a lot. This code was a lot more complicated than it had to be.

Moved all lcd writing to ui.lua. ui_init.lua and all the functions called by it will now return a table containing a function and a string.

Test version here:
betaflight-tx-lua-scripts_1.5.0.zip

@klutvott123 klutvott123 added this to the 1.6 milestone May 9, 2021
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of language 😆 LGTM

@klutvott123 klutvott123 mentioned this pull request May 15, 2021
@mikeller mikeller merged commit 1daa86b into betaflight:master May 21, 2021
@klutvott123 klutvott123 deleted the popup-improvements branch November 26, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants