Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc update #394

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Rc update #394

merged 2 commits into from
Oct 31, 2021

Conversation

klutvott123
Copy link
Member

Updates feedforward and rc smoothing settings for BF 4.3 according to betaflight/betaflight#10723 and betaflight/betaflight#10650

screenshot_x7_21-05-24_22-57-29
screenshot_x7_21-05-24_22-56-49
screenshot_x7_21-05-24_22-56-43

fields[#fields + 1] = { t = "Cutoff", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 255, vals = { 27 }, table = { [0] = "Auto" } }
fields[#fields + 1] = { t = "Type", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 3, vals = { 29 }, table = { [0] = "Off", "PT1", "BIQUAD", "Auto"} }
end
if apiVersion >= 1.040 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this block be moved to line 39?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Usually we're more worried about getting things in the "right" order and that sometimes means multiple checks for the same api version. In this case it's fine if we combine them. The order of things won't make any less sense than it currently does. lol

fields[#fields + 1] = { t = "Boost", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 50, vals = { 53 } }
labels[#labels + 1] = { t = "Feedforward", x = x, y = inc.y(lineSpacing) }
fields[#fields + 1] = { t = "Transition", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 100, vals = { 9 }, scale = 100 }
if apiVersion >= 1.044 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, the conditional is not needed anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. We want to show these parameters for api version 1.044 and up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops color blindness, reading too long I guess 🤦‍♂️

@mikeller mikeller merged commit 2102034 into betaflight:master Oct 31, 2021
@klutvott123 klutvott123 deleted the rc-update branch November 26, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants