PWM page improvements #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutvott123
force-pushed
the
pwm-page-improvements
branch
3 times, most recently
from
795c457 to
30cc6c0
Compare
TheIsotopes
suggested changes
Oct 27, 2021
src/SCRIPTS/BF/board_info.lua
Outdated
| io.write(f, " i2cRegisteredDeviceCount = "..tostring(i2cRegisteredDeviceCount)..",", "\n") | ||
| io.write(f, "}", "\n") | ||
| io.close(f) | ||
| assert(loadScript("/BF/BOARD_INFO/"..mcuId..".lua", 'c')) |
There was a problem hiding this comment.
should be assert(loadScript("/SCRIPTS/BF/BOARD_INFO/"..mcuId..".lua", 'c'))
There was a problem hiding this comment.
But actually it should just be assert(loadScript("BOARD_INFO/"..mcuId..".lua", 'c'))
Because we're changing the working directory here
There was a problem hiding this comment.
Scratch that. Looks like the io library doesn't care about the working directory and expects the full path.
There was a problem hiding this comment.
Scratch that too. We just need to make sure that the BOARD_INFO folder actually exists. Made the folder and added a readme.txt to it to explain what it's there for. Works as expected now.
klutvott123
force-pushed
the
pwm-page-improvements
branch
from
30cc6c0 to
7e54d5c
Compare
TheIsotopes
previously approved these changes
Oct 28, 2021
klutvott123
force-pushed
the
pwm-page-improvements
branch
2 times, most recently
from
e2bafae to
d41a79f
Compare
klutvott123
force-pushed
the
pwm-page-improvements
branch
from
d41a79f to
51d9267
Compare
mikeller
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gyro UpdateandPID Loopto the PWM page.Looks like this now