Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost MSP support #419

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Ghost MSP support #419

merged 1 commit into from
Sep 2, 2022

Conversation

daleckystepan
Copy link
Member

@daleckystepan daleckystepan commented Jan 7, 2022 •
edited
Loading

Add MSP support for Ghost

Need new Ghost FW v1.0.6.0+

BF: betaflight/betaflight#11242
ETX: EdgeTX/edgetx#1377

@daleckystepan daleckystepan mentioned this pull request Jan 7, 2022
Merged
@haslinghuis haslinghuis added this to the 1.6 milestone Jan 7, 2022
haslinghuis
haslinghuis previously approved these changes Jan 7, 2022
View reviewed changes
@daleckystepan daleckystepan changed the title Ghost MSP support [WIP] Ghost MSP support Jan 7, 2022
@daleckystepan daleckystepan mentioned this pull request Jan 7, 2022
Merged
@daleckystepan
Copy link
Member Author

daleckystepan commented Jan 7, 2022 •
edited
Loading

@TheIsotopes It is not ready yet for testing. I will let you know once it will be. Intention of this PR is to create place where we can discuss it etc. You are really fast :D

@klutvott123 klutvott123 modified the milestones: 1.6, 1.7 Jan 8, 2022
@klutvott123
Copy link
Member

@daleckystepan Good job on this and the rest of the PRs to go with it 👍
I'm moving this to the 1.7 milestone since the firmware side of it is for 4.4.

@daleckystepan daleckystepan changed the title [WIP] Ghost MSP support Ghost MSP support Jan 11, 2022
@TheIsotopes TheIsotopes mentioned this pull request Jan 11, 2022
Merged
klutvott123
klutvott123 reviewed Jan 22, 2022
View reviewed changes
src/SCRIPTS/BF/MSP/ghost.lua Outdated
local GHST_FRAMETYPE_MSP_WRITE = 0x22
local GHST_FRAMETYPE_MSP_RESP = 0x28

ghstMspType = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be local ghstMspType = 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

klutvott123
klutvott123 reviewed Jan 22, 2022
View reviewed changes
src/SCRIPTS/BF/MSP/ghost.lua Outdated
Comment on lines 1 to 4
-- GHOST Frame Types
local GHST_FRAMETYPE_MSP_REQ = 0x21
local GHST_FRAMETYPE_MSP_WRITE = 0x22
local GHST_FRAMETYPE_MSP_RESP = 0x28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have fewer spaces here?
I see that were calling it both "ghst" and "ghost". Which one is the "correct" one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer ghst as it goes nice with csrf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@klutvott123 klutvott123 mentioned this pull request Jan 22, 2022
Merged
@daleckystepan daleckystepan mentioned this pull request Jun 22, 2022
Closed
@haslinghuis haslinghuis merged commit 9992b5d into betaflight:master Sep 2, 2022
@carbendi
Copy link

carbendi commented Sep 22, 2022 •
edited
Loading

Is Ghost MSP working now?
Getting stuck at "downloading board info" after compiling and running the betaflight lua script.
Jumper T16
Edgetx 2.7.1
BF 4.4 latest
Ghost 1.0.6.5

@haslinghuis
Copy link
Member

Try latest nightly viewer: https://github.com/betaflight/blackbox-log-viewer-nightlies/releases/tag/v20220921.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis left review comments

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees

@daleckystepan daleckystepan

Labels
needs coordination with firmware RN: IMPROVEMENT
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@daleckystepan @klutvott123 @carbendi @haslinghuis