Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shebang in bin/build.sh #438

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

sorki
Copy link
Contributor

@sorki sorki commented May 31, 2022

Using env is a more portable approach.

Using env is a more portable approach.
@haslinghuis
Copy link
Member

Good find. But not sure if we need anything to fix.

https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash

@sorki
Copy link
Contributor Author

sorki commented Jun 1, 2022

I found it by cloning the repo and trying to run make to test vs betaflight 4.3. My distro (NixOS) doesn't have /bin/bash (not even /usr/bin/bash) so we need to use env. The change is pretty harmless and should work everywhere.

@haslinghuis haslinghuis self-assigned this Jun 2, 2022
@haslinghuis haslinghuis merged commit 0d9f8f4 into betaflight:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants