Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassembly context support for tool call response message #463

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

David-Buyer
Copy link
Contributor

Refactoring of class "ReassemblyContext" for CreateCompletionAsStream() service API. It replaces the logic about reassembly tool/function calls in mode == "stream" processing to extend and adjust the previous behavior about legacy/deprecated function calls. It allows to get at higher level the same previous reassembled function calls, with the newest API model by tool calls. It works just with ToolCall.Type == "function", but it could be extended in future if new features are introduced following a similar behavior.

@kayhantolga kayhantolga added the Ready for next version This issue solved and waiting for next release label Jan 31, 2024
@kayhantolga
Copy link
Member

I have made some small changes. Please take a look and share your feedback.

@kayhantolga kayhantolga linked an issue Jan 31, 2024 that may be closed by this pull request
@David-Buyer
Copy link
Contributor Author

I have made some small changes. Please take a look and share your feedback.

Better revision, good. I've tried to keep the previous naming convention, but that one you've applied is the same i usually use, so better approach, yes. In general, for me, all you have modified is good way to proceed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for next version This issue solved and waiting for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function calling was broken
2 participants