-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip/new to nl 2 #658
Draft
rsmithlal
wants to merge
334
commits into
main
Choose a base branch
from
wip/new-to-nl-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Wip/new to nl 2 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content and rich text blocks
…ren are non-existent or non-visible
…etter_together inside host app
Show share buttons on pages#show, communities#show, and people#show if their privacy is set to public
Dispatch page view metric background job in show action of communities, people, and pages controllers
dispatch job in controller after intercepting link clicks in the body
allow dispatching using background job
…rl request to main_app For some reason, the controllers from the main_app are experiencing problems with the route lookup when rendering the locale_switcher. This fixes it for now by catching teh error and delegating it to the main_app helper
…itcher url request to main_app" This reverts commit cc5c2e2.
…ds of trouble with url generation!
Signed-off-by: Robert Smith <[email protected]>
…cy and the creation of the first user during the setup wizard
Signed-off-by: Robert Smith <[email protected]>
Signed-off-by: Robert Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made as part of the Wayfinder Project in partnership with Collective Interchange.
https://github.com/collective-interchange-coop/new-to-nl
Summary: Wayfinder Enhancements and Fixes
This pull request introduces a comprehensive set of updates, optimizations, and new features for the Wayfinder Project in partnership with Collective Interchange. The changes include enhancements to navigation, content blocks, caching, localization, and accessibility, as well as various bug fixes and performance improvements.
Key Changes:
1. Navigation Improvements:
2. Content Block Enhancements:
3. Caching and Performance Optimization:
4. Localization and Translation:
5. Notifications and Messaging:
noticed
gem for in-app notifications.6. Metrics and Analytics:
7. Accessibility and UI Enhancements:
8. Bug Fixes:
Technical Improvements:
better_together
namespace.Future Considerations:
This PR establishes a solid foundation for upcoming features, including: