Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Real/unscaled time timer run condition #10177

Closed
SecretPocketCat opened this issue Oct 18, 2023 · 0 comments · Fixed by #10179
Closed

Add Real/unscaled time timer run condition #10177

SecretPocketCat opened this issue Oct 18, 2023 · 0 comments · Fixed by #10179
Labels
A-ECS Entities, components, systems, and events A-Time Involves time keeping and reporting C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@SecretPocketCat
Copy link
Contributor

SecretPocketCat commented Oct 18, 2023 •
edited
Loading

What problem does this solve or what need does it fill?

#8964 added time scaling and the current on_timer now scales with that which is as expected, but it would be nice to have an unscaled alternative.

What solution would you like?

Add a new timer run condition that uses real/unscaled time.

What alternative(s) have you considered?

Make the current run condition generic over the type of Time<T>.
@SecretPocketCat SecretPocketCat added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 18, 2023
@SecretPocketCat SecretPocketCat mentioned this issue Oct 18, 2023
Merged
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events A-Time Involves time keeping and reporting C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled C-Feature A new feature, making something new possible labels Oct 19, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 20, 2023
@SecretPocketCat
add on_real_time_timer run condition (#10179)
b1cc7ad 
# Objective

Fixes #10177 .

## Solution

Added a new run condition and tweaked the docs for `on_timer`.

## Changelog

### Added 
 - `on_real_time_timer` run condition
ameknite pushed a commit to ameknite/bevy that referenced this issue Nov 6, 2023
@SecretPocketCat @ameknite
add on_real_time_timer run condition (bevyengine#10179)
372734a 
# Objective

Fixes bevyengine#10177 .

## Solution

Added a new run condition and tweaked the docs for `on_timer`.

## Changelog

### Added 
 - `on_real_time_timer` run condition
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@SecretPocketCat
add on_real_time_timer run condition (bevyengine#10179)
1d6e53d 
# Objective

Fixes bevyengine#10177 .

## Solution

Added a new run condition and tweaked the docs for `on_timer`.

## Changelog

### Added 
 - `on_real_time_timer` run condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Time Involves time keeping and reporting C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add on_real_time_timer run condition SecretPocketCat/bevy
2 participants
@alice-i-cecile @SecretPocketCat