Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning is output to console when running with file_watcher enabled #10401

Closed
RyeToastyO opened this issue Nov 6, 2023 · 0 comments · Fixed by #10787
Closed

Warning is output to console when running with file_watcher enabled #10401

RyeToastyO opened this issue Nov 6, 2023 · 0 comments · Fixed by #10787
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Milestone

Comments

@RyeToastyO
Copy link

Bevy version

0.12.0

What you did

It happens whenever I run my project with file_watcher enabled

What went wrong

Hot reloading works, but I get this warning:
WARN bevy_asset::io::source: AssetSourceId::Name(embedded) does not have an AssetWatcher configured. Consider enabling the "file_watcher" feature. Note that Web and Android do not currently support watching assets.

Additional information

I mentioned it in the assets-dev channel and cart said:
"[It's] too noisy/wrong. It's because we warn when any source doesn't support watching when watching is enabled for one source. We'll need to be a bit smarter about how we warn about these things."

@RyeToastyO RyeToastyO added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Nov 6, 2023
@cart cart added this to the 0.12.1 milestone Nov 6, 2023
@cart cart added A-Assets Load files from disk to use for things like images, models, and sounds and removed S-Needs-Triage This issue needs to be labelled labels Nov 6, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2023
…10787)

# Objective

Fixes #10401 

## Solution

* Allow sources to register specific processed/unprocessed watch
warnings.
* Specify per-platform watch warnings. This removes the need to cover
all platform cases in one warning message.
* Only register watch warnings for the _processed_ embedded source, as
warning about watching unprocessed embedded isn't helpful.

---

## Changelog

- Asset sources can now register specific watch warnings.
cart added a commit that referenced this issue Nov 30, 2023
…10787)

# Objective

Fixes #10401 

## Solution

* Allow sources to register specific processed/unprocessed watch
warnings.
* Specify per-platform watch warnings. This removes the need to cover
all platform cases in one warning message.
* Only register watch warnings for the _processed_ embedded source, as
warning about watching unprocessed embedded isn't helpful.

---

## Changelog

- Asset sources can now register specific watch warnings.
james7132 pushed a commit to james7132/bevy that referenced this issue Dec 1, 2023
…evyengine#10787)

# Objective

Fixes bevyengine#10401 

## Solution

* Allow sources to register specific processed/unprocessed watch
warnings.
* Specify per-platform watch warnings. This removes the need to cover
all platform cases in one warning message.
* Only register watch warnings for the _processed_ embedded source, as
warning about watching unprocessed embedded isn't helpful.

---

## Changelog

- Asset sources can now register specific watch warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants