Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fake variadics to Reflect impls #15208

Closed
janhohenheim opened this issue Sep 15, 2024 · 1 comment
Closed

Add fake variadics to Reflect impls #15208

janhohenheim opened this issue Sep 15, 2024 · 1 comment
Assignees
@BenjaminBrienen
Labels
A-Reflection Runtime information about types C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Comments

@janhohenheim
Copy link
Member

janhohenheim commented Sep 15, 2024 •
edited
Loading

How can Bevy's documentation be improved?

@bash added lovely fake variadics for the documentation of all_tuples!. See #14697

The same can be done for impl_reflect_tuple! :)

Anyone tackling this can just copy the approach taken in the linked issue, so this should be straightforward
@janhohenheim janhohenheim added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled A-Reflection Runtime information about types S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Sep 15, 2024
@BenjaminBrienen
Copy link
Contributor

?claim

@BenjaminBrienen BenjaminBrienen mentioned this issue Sep 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
@BenjaminBrienen
Documentation for variadics (#15387)
c841dd9 
# Objective

Relevant: #15208

## Solution

I went ahead and added the variadics documentation in all applicable
locations.

## Testing

- I built the documentation and inspected it to see whether the feature
is there.
robtfm pushed a commit to robtfm/bevy that referenced this issue Oct 4, 2024
@BenjaminBrienen @robtfm
Documentation for variadics (bevyengine#15387)
e5c8082 
# Objective

Relevant: bevyengine#15208

## Solution

I went ahead and added the variadics documentation in all applicable
locations.

## Testing

- I built the documentation and inspected it to see whether the feature
is there.
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Reflection Runtime information about types C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janhohenheim @BenjaminBrienen