Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add position and rotation components to Camera entities #3

Closed
cart opened this issue May 6, 2020 · 1 comment
Closed

Add position and rotation components to Camera entities #3

cart opened this issue May 6, 2020 · 1 comment
Labels
C-Feature A new feature, making something new possible
Milestone
Open Source Release

Comments

@cart
Copy link
Member

cart commented May 6, 2020

Currently camera position and rotation must be handled by directly modifying the Transform component.

This should be reconciled with manually setting the Transform (ex: calling look_at()). We don't want position and rotation components overriding manually set transforms.
@cart cart added the C-Feature A new feature, making something new possible label May 6, 2020
@cart cart added this to the Open Source Release milestone May 6, 2020
@cart
Copy link
Member Author

cart commented May 31, 2020

Fixed by 21a79c5, which adds the ability to toggle syncing from pos/rot components to transforms. But this isn't an ideal solution. I would prefer it if changes to LocalToWorld transforms automatically synced to Translation, Rotation, Scale components and vice-versa, but I'm pretty sure we need component change events for that to work properly.

@cart cart closed this as completed May 31, 2020
@aclysma aclysma mentioned this issue Aug 24, 2020
Closed
aclysma added a commit to aclysma/bevy that referenced this issue Aug 29, 2020
@aclysma
Bevy tasks (bevyengine#3)
6227612 
* Address some feedback for the bevy_tasks PR
 - Add a general clamp fn to bevy_math
 - Expose num_cpus in bevy_tasks
 - Fill out empty doc comment

* Add comments and clean up pinning in bevy_tasks, fix a couple tests
@NathanSWard NathanSWard mentioned this issue Jun 5, 2021
Closed
4 tasks
superdump referenced this issue in superdump/bevy Jun 19, 2021
@superdump
StandardMaterial flat values (#3)
334a857 
StandardMaterial flat values
cart pushed a commit that referenced this issue Jul 24, 2021
@superdump @cart
StandardMaterial flat values (#3)
1b81a54 
StandardMaterial flat values
cart pushed a commit that referenced this issue Jul 24, 2021
@superdump @cart
StandardMaterial flat values (#3)
01116b1 
StandardMaterial flat values
@dman-os dman-os mentioned this issue Aug 15, 2021
Open
bors bot pushed a commit that referenced this issue Oct 3, 2021
@Frizi
Merge pull request #3 from TheRawMeatball/fix-derive-component-again
fd62374
bilsen added a commit to bilsen/bevy that referenced this issue Oct 4, 2021
@bilsen
code dump bevyengine#3
6f6eacd
bors bot pushed a commit that referenced this issue Mar 29, 2022
@Looooong @james7132 @mockersf
Mesh Skinning. Attempt #3 (#4238)
31bd4ec 
# Objective
Load skeletal weights and indices from GLTF files. Animate meshes.

## Solution
 - Load skeletal weights and indices from GLTF files.
 - Added `SkinnedMesh` component and ` SkinnedMeshInverseBindPose` asset
 - Added `extract_skinned_meshes` to extract joint matrices.
 - Added queue phase systems for enqueuing the buffer writes.

Some notes:

 -  This ports part of # #2359 to the current main.
 -  This generates new `BufferVec`s and bind groups every frame. The expectation here is that the number of `Query::get` calls during extract is probably going to be the stronger bottleneck, with up to 256 calls per skinned mesh. Until that is optimized, caching buffers and bind groups is probably a non-concern.
 - Unfortunately, due to the uniform size requirements, this means a 16KB buffer is allocated for every skinned mesh every frame. There's probably a few ways to get around this, but most of them require either compute shaders or storage buffers, which are both incompatible with WebGL2.

Co-authored-by: james7132 <[email protected]>
Co-authored-by: François <[email protected]>
Co-authored-by: James Liu <[email protected]>
aevyrie pushed a commit to aevyrie/bevy that referenced this issue Jun 7, 2022
@Looooong @james7132
@mockersf @aevyrie
Mesh Skinning. Attempt bevyengine#3 (bevyengine#4238)
a370aef 
# Objective
Load skeletal weights and indices from GLTF files. Animate meshes.

## Solution
 - Load skeletal weights and indices from GLTF files.
 - Added `SkinnedMesh` component and ` SkinnedMeshInverseBindPose` asset
 - Added `extract_skinned_meshes` to extract joint matrices.
 - Added queue phase systems for enqueuing the buffer writes.

Some notes:

 -  This ports part of # bevyengine#2359 to the current main.
 -  This generates new `BufferVec`s and bind groups every frame. The expectation here is that the number of `Query::get` calls during extract is probably going to be the stronger bottleneck, with up to 256 calls per skinned mesh. Until that is optimized, caching buffers and bind groups is probably a non-concern.
 - Unfortunately, due to the uniform size requirements, this means a 16KB buffer is allocated for every skinned mesh every frame. There's probably a few ways to get around this, but most of them require either compute shaders or storage buffers, which are both incompatible with WebGL2.

Co-authored-by: james7132 <[email protected]>
Co-authored-by: François <[email protected]>
Co-authored-by: James Liu <[email protected]>
bors bot pushed a commit that referenced this issue Nov 3, 2022
@JMS55
Merge pull request #3 from DGriffin91/bloom-node-new
cea7545 
support for camera_2d
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@Looooong @james7132
@mockersf @ItsDoot
Mesh Skinning. Attempt bevyengine#3 (bevyengine#4238)
14913f1 
# Objective
Load skeletal weights and indices from GLTF files. Animate meshes.

## Solution
 - Load skeletal weights and indices from GLTF files.
 - Added `SkinnedMesh` component and ` SkinnedMeshInverseBindPose` asset
 - Added `extract_skinned_meshes` to extract joint matrices.
 - Added queue phase systems for enqueuing the buffer writes.

Some notes:

 -  This ports part of # bevyengine#2359 to the current main.
 -  This generates new `BufferVec`s and bind groups every frame. The expectation here is that the number of `Query::get` calls during extract is probably going to be the stronger bottleneck, with up to 256 calls per skinned mesh. Until that is optimized, caching buffers and bind groups is probably a non-concern.
 - Unfortunately, due to the uniform size requirements, this means a 16KB buffer is allocated for every skinned mesh every frame. There's probably a few ways to get around this, but most of them require either compute shaders or storage buffers, which are both incompatible with WebGL2.

Co-authored-by: james7132 <[email protected]>
Co-authored-by: François <[email protected]>
Co-authored-by: James Liu <[email protected]>
Selene-Amanita added a commit to Selene-Amanita/bevy that referenced this issue May 27, 2023
@Selene-Amanita @harudagondi
Document query errors suggested change bevyengine#3
28c9b52 
Co-authored-by: harudagondi <[email protected]>
@Patryk27 Patryk27 mentioned this issue Nov 18, 2023
Closed
tigregalis pushed a commit to tigregalis/bevy that referenced this issue Jun 17, 2024
@TotalKrill
Merge pull request bevyengine#3 from nicoburns/cosmic-text-no-buffer-…
b8fcd5e 
…mutex

Remove Mutex around `Buffer`
mate-h pushed a commit to mate-h/bevy that referenced this issue Jan 18, 2025
@ecoskey
Merge pull request bevyengine#3 from mate-h/proc_sky
9f59275 
Procedural sky integration corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Feature A new feature, making something new possible
Projects
None yet
Milestone
Open Source Release
Development

No branches or pull requests
1 participant
@cart