Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform_hierarchy example doesn't seem to do anything #7433

Closed
rparrett opened this issue Jan 31, 2023 · 4 comments · Fixed by #14374
Closed

transform_hierarchy example doesn't seem to do anything #7433

rparrett opened this issue Jan 31, 2023 · 4 comments · Fixed by #14374
Labels
A-Transform Translations, rotations and scales C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@rparrett
Copy link
Contributor

rparrett commented Jan 31, 2023 •
edited
Loading

Bevy version

main

Relevant system information

AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
SystemInfo { os: "MacOS 13.1 ", kernel: "22.2.0", cpu: "Apple M1 Max", core_count: "10", memory: "64.0 GiB" }

What you did

cargo run --release --example transform_hierarchy chain

What went wrong

It's not clear how to use this tool to stress test things.

I had assumed that it was meant to be used with the tracing feature, but I don't think that works without LogPlugin, which isn't included in MinimalPlugins. At least, I can't get tracy to connect to it.

Additionally, it looks like it probably should have HierarchyPlugin.

Additional information

Discovered this while attempting to benchmark #7264
@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jan 31, 2023
@rparrett rparrett changed the title transform_hierarchy stress test does not work transform_hierarchy doesn't do anything Jan 31, 2023
@rparrett
Copy link
Contributor Author

Rewriting this issue...

@rparrett rparrett changed the title transform_hierarchy doesn't do anything transform_hierarchy example doesn't seem to do anything Jan 31, 2023
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Transform Translations, rotations and scales and removed S-Needs-Triage This issue needs to be labelled labels Jan 31, 2023
@rparrett rparrett mentioned this issue Sep 11, 2023
Open
@NthTensor NthTensor mentioned this issue Feb 7, 2024
Closed
@alice-i-cecile alice-i-cecile added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Trivial Nice and easy! A great choice to get started with Bevy labels Jul 14, 2024
@alice-i-cecile
Copy link
Member

We should just remove this at this point.

@alice-i-cecile alice-i-cecile added the X-Uncontroversial This work is generally agreed upon label Jul 14, 2024
@BD103 BD103 mentioned this issue Jul 15, 2024
Closed
@rparrett
Copy link
Contributor Author

I hadn't seen #11760 until I looked over this issue again today, but it looks like this example was useful over there with a very small modification: using DefaultPlugins instead of MinimalPlugins.

@rparrett rparrett mentioned this issue Jul 17, 2024
Merged
@rparrett
Copy link
Contributor Author

rparrett commented Jul 17, 2024 •
edited
Loading

Opened #14374 as an alternative PR.

github-merge-queue bot pushed a commit that referenced this issue Jul 20, 2024
@rparrett
Fix tracing with transform_hierarchy example (#14374)
490792b 
# Objective

Fixes #7433
Alternative to #14323

## Solution

Add `DefaultPlugins` so we actually have tracing spans when using
`trace_tracy` or `trace_chrome`.

## Testing

```
cargo run --release --features trace_tracy --example transform_hierarchy large_tree
```
This now connects to Tracy and sends a bunch of data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
2 participants
@rparrett @alice-i-cecile