Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining clippy lint definitions to Cargo.toml #10672

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Move remaining clippy lint definitions to Cargo.toml #10672

merged 2 commits into from
Nov 28, 2023

Conversation

AlexOkafor
Copy link
Contributor

@AlexOkafor AlexOkafor commented Nov 21, 2023 •
edited
Loading

Objective

Partially addresses #10612
After moving the initial docs_markdown warning, this is a PR that moves the rest of the CI clippy lint definitions to the cargo.toml.

Solution

  • the tools/ci/src/main.rs clippy lints removed and just the warning flag remains.
  • the warnings moved to the root cargo workspace toml.

@AlexOkafor AlexOkafor changed the title Move remaining clippy lint definitions to cargo.toml Move remaining clippy lint definitions to Cargo.toml Nov 21, 2023
@AlexOkafor
remove the clippy_flags constants
b644cb5 
since there isn't a need to have an array anymore, the deny flag is just sent to the shell command directly.
@Kanabenki Kanabenki added C-Feature A new feature, making something new possible A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change labels Nov 21, 2023
@james7132 james7132 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed C-Feature A new feature, making something new possible labels Nov 25, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 28, 2023
Merged via the queue into bevyengine:main with commit 3c2cbb8 Nov 28, 2023
1 check passed
@AlexOkafor AlexOkafor deleted the lint-tables-continued branch November 28, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexOkafor @killercup @james7132 @alice-i-cecile @Kanabenki