Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better doc for SystemName #11084

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Better doc for SystemName #11084

merged 1 commit into from
Dec 25, 2023

Conversation

stepancheg
Copy link
Contributor

Compared to current documentation it is now immediately clear that it is SystemParam readily available to user, and not just some accidentally exposed internal data type.

alice-i-cecile
alice-i-cecile approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think this is an improvement :)

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Dec 24, 2023
Nilirad
Nilirad approved these changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@Nilirad Nilirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would it be appropriate to add a comment that shows what the logger prints?

@stepancheg
Copy link
Contributor Author

Added.

@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 24, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 25, 2023
Merged via the queue into bevyengine:main with commit ac58a5f Dec 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiqo15 matiqo15 matiqo15 approved these changes

@Nilirad Nilirad Nilirad approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancheg @alice-i-cecile @Nilirad @matiqo15