-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump toml_edit in build-template-pages tool #11342
Conversation
Also only enable the parser feature. The other default feature, display, is not needed in this circumstance.
This involves toggling off Tera's default features so crates such as rand are not pulled in. The only thing I had to do was recreate the slugify filter, since that is used in a template.
I don't think taking the same complexity of slugify is worth a 3 seconds decrease |
What do you mean by this? Do you think manually registering the filter is too complex, or do you think we shouldn't pull in the Another idea I had was to just move the function into |
That I prefer to keep depending on the default features, 3 seconds on the build time on a tool not on a critical path doesn't seem a big enough gain |
Ok. I'll revert the Tera commit but keep the other one. |
This reverts commit 631308b. See bevyengine#11342 (comment)
After looking at the most recent CI run, it appears that the Tera commit was the only thing providing any sort of time gains. (Compile times are back to 26.5 seconds.) I'm going to rename the PR and rewrite the description to make it just a version bump, because that's all it is at this point. |
from #11357 it's also used in other places. would it makes sense to also remove the default features there? and could you update it everywhere? |
I bumped $ cargo tree -i toml_edit
error: There are multiple `toml_edit` packages in your project, and the specification `toml_edit` is ambiguous.
Please re-run this command with one of the following specifications:
[email protected]
[email protected] It appears that $ cargo tree --target all -i [email protected]
toml_edit v0.19.15
└── proc-macro-crate v1.3.1
└── num_enum_derive v0.5.11 (proc-macro)
└── num_enum v0.5.11
└── ndk v0.7.0
├── cpal v0.15.2
│ └── rodio v0.17.3
│ └── bevy_audio v0.12.0 (/Users/bdeep/dev/bevy/bevy/crates/bevy_audio)
│ └── bevy_internal v0.12.0 (/Users/bdeep/dev/bevy/bevy/crates/bevy_internal)
│ └── bevy v0.12.0 (/Users/bdeep/dev/bevy/bevy)
└── oboe v0.5.0
├── bevy_audio v0.12.0 (/Users/bdeep/dev/bevy/bevy/crates/bevy_audio) (*)
└── cpal v0.15.2 (*) |
Objective
build-templated-pages
tool is used to render the Markdown templates in the docs-template folder.toml_edit
.Solution
toml_edit
to 0.21, disabling all features exceptparse
.