Add many_materials stress test #11592
Conversation
|
Whoops good catch. That was leftovers from testing a bug in bevy main that im gonna be opening an issue for soon |
|
The generated |
|
The generated |
1 similar comment
|
The generated |
alice-i-cecile
added
A-Rendering
| mut meshes: ResMut<Assets<Mesh>>, | ||
| mut materials: ResMut<Assets<StandardMaterial>>, | ||
| ) { | ||
| let n = 4; |
There was a problem hiding this comment.
Since this is a stress test this should probably be configurable using argh. Something like bevymark.
There was a problem hiding this comment.
Maybe giving it a specific amount would be more useful though.
There was a problem hiding this comment.
If you're making it configurable with argh, please copy the cfg blocks from the other stress tests using it (eg. many_cubes) as argh::from_env() panics in wasm.
alice-i-cecile
added
the
S-Ready-For-Final-Review
| }); | ||
|
|
||
| // Helmets | ||
| let helmet = asset_server.load("models/FlightHelmet/FlightHelmet.gltf#Scene0"); |
There was a problem hiding this comment.
using the helmet instead of a pbrbundle means you're also adding hierarchy and complex meshes to the stress test
it also means we don't have direct control of the material and can't try easily if it's because one of the property of it
I would prefer to use a PbrBundle as it makes a more focused stress test, and it wouldn't need the make_materials_unique system
There was a problem hiding this comment.
Hmm, I think I agree with this analysis. It would be better to be able to properly isolate the effects here.
alice-i-cecile
removed
the
S-Ready-For-Final-Review
Co-authored-by: François <[email protected]>
|
The generated |
# Objective - This PR adds a new stress test called `many_materials` to benchmark the rendering performance of many animated materials. - Fixes #11588 - This PR continues the work started in the previous PR #11592, which was closed due to inactivity. ## Solution - Created a new example (`examples/stress_tests/many_materials.rs`) that renders a grid of cubes with animated materials. - The size of the grid can be configured using the `-n` command-line argument (or `--grid-size`). The default grid size is 10x10. - The materials animate by cycling through colors in the HSL color space. ## Testing - I have tested these changes locally on my Linux machine. - Reviewers can test the changes by running the example with different grid sizes and observing the performance (FPS, frame time). - I have not tested on other platforms (macOS, Windows, wasm), but I expect it to work as the code uses standard Bevy features. --- ## Showcase <details> <summary>Click to view showcase</summary>  </details>
# Objective - This PR adds a new stress test called `many_materials` to benchmark the rendering performance of many animated materials. - Fixes bevyengine#11588 - This PR continues the work started in the previous PR bevyengine#11592, which was closed due to inactivity. ## Solution - Created a new example (`examples/stress_tests/many_materials.rs`) that renders a grid of cubes with animated materials. - The size of the grid can be configured using the `-n` command-line argument (or `--grid-size`). The default grid size is 10x10. - The materials animate by cycling through colors in the HSL color space. ## Testing - I have tested these changes locally on my Linux machine. - Reviewers can test the changes by running the example with different grid sizes and observing the performance (FPS, frame time). - I have not tested on other platforms (macOS, Windows, wasm), but I expect it to work as the code uses standard Bevy features. --- ## Showcase <details> <summary>Click to view showcase</summary>  </details>
Objective
Solution