Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for async pipeline creation on RenderPlugin #11847

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Add configuration for async pipeline creation on RenderPlugin #11847

merged 6 commits into from
Feb 16, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Feb 13, 2024 •
edited
Loading

Objective

Fixes #11846

Solution

Add a synchronous_pipeline_compilation field to RenderPlugin, defaulting to false.

Most of the diff is whitespace.

Changelog

Added synchronous_pipeline_compilation to RenderPlugin for disabling async pipeline creation.

Migration Guide

TODO: consider combining this with the guide for #11846

RenderPlugin has a new synchronous_pipeline_compilation property. The default value is false. Set this to true if you want to retain the previous synchronous behavior.

@rparrett rparrett marked this pull request as draft February 13, 2024 15:29
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 13, 2024
@rparrett rparrett marked this pull request as ready for review February 13, 2024 15:58
@alice-i-cecile alice-i-cecile requested a review from JMS55 February 15, 2024 17:30
JMS55
JMS55 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

crates/bevy_render/src/lib.rs Outdated Show resolved Hide resolved
crates/bevy_render/src/lib.rs Outdated Show resolved Hide resolved
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 15, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 16, 2024
@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Feb 16, 2024
Merged via the queue into bevyengine:main with commit ebaa347 Feb 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow async pipeline creation to be disabled
4 participants
@rparrett @mockersf @JMS55 @alice-i-cecile