Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove naga_oil dependency from bevy_pbr #11914

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Remove naga_oil dependency from bevy_pbr #11914

merged 1 commit into from
Feb 17, 2024

Conversation

rparrett
Copy link
Contributor

Objective

Fixes #11908

Solution

  • Remove the naga_oil dependency from bevy_pbr.
  • We were doing a little dance to disable glsl support on not-wasm, so incorporate that dance into bevy_render's Cargo.toml.

@rparrett rparrett changed the title Remove naga_oil dependency from bevy_pbr Remove naga_oil dependency from bevy_pbr Feb 17, 2024
@james7132 james7132 requested review from JMS55 and pcwalton February 17, 2024 02:14
@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Feb 17, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 17, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 17, 2024
@alice-i-cecile
Copy link
Member

Squeaking this in to 0.13: this is a frustrating little issue.

Merged via the queue into bevyengine:main with commit 756535b Feb 17, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

@JMS55 JMS55 Awaiting requested review from JMS55

@pcwalton pcwalton Awaiting requested review from pcwalton

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2d project without default-features fails to compile without bevy_pbr feature on wasm targets
3 participants
@rparrett @alice-i-cecile @james7132