-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glam version requirement from 0.25 to 0.27 #12757
Conversation
Bevy does re-export structs from
|
this PR should also update hexasphere to 0.12, and is blocked on encase releasing an updated version using glam 0.27 |
Pushed an update to bump hexaspere version requirement. We'll wait for a new |
Just published encase v0.8. |
d8456f0
to
73ba70b
Compare
I think it's very niche, but it certainly doesn't hurt to mention it |
73ba70b
to
5929885
Compare
@mockersf rebased and updated the Migration Guide with some details on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I had a question about the linear rgb change.
@alice-i-cecile Can we just commit that suggested change and add this to the queue? It's a one liner, and this is blocking some other stuff. |
Commited the change and rebased. @alice-i-cecile @mockersf we should be able to merge now. |
Objective
Solution
glam
version requirement from 0.25 to 0.27.encase
andencase_derive_impl
version requirement from 0.7 to 0.8.hexasphere
version requirement from 10.0 to 12.0.Migration Guide
glam
exports, keep in mind thatvector
fract()
method now matches Rust implementation (that isself - self.trunc()
instead ofself - self.floor()
). If you want to use the GLSL implementation you should now usefract_gl()
.