Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: pass the untransformed node size to the shader #12839

Merged

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Apr 1, 2024

Objective

Solution

  • Pass the untransformed node size to the shader

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Apr 1, 2024
@mockersf mockersf added this to the 0.14 milestone Apr 1, 2024
@JMS55
Copy link
Contributor

JMS55 commented Apr 2, 2024

Do we have an example/test for this? If not, do you mind adding one? This is the second time we've seen a UI rotation bug like this :(

@mockersf
Copy link
Member Author

mockersf commented Apr 2, 2024

It's used in two examples: pbr and overflow_debug. I would prefer to not add a dedicated example as modifying the transform of ui nodes is not something I would like to encourage until we have a good solution for in-layout and out-of-layout rotations

@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 24, 2024
@mockersf mockersf added this pull request to the merge queue Apr 26, 2024
Merged via the queue into bevyengine:main with commit 75f1c5d Apr 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants