Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cone Mesh #13157

Closed
wants to merge 3 commits into from
Closed

Cone Mesh #13157

wants to merge 3 commits into from

Conversation

ManevilleF
Copy link
Contributor

@ManevilleF ManevilleF commented May 1, 2024 •
edited
Loading

Objective

Make the cone primitive meshable

Solution

Create a ConeMeshBuilder

Screenshot 2024-05-01 at 15 11 57

@ManevilleF
Copy link
Contributor Author

ManevilleF commented May 1, 2024 •
edited
Loading

Just noticed this is a duplicate of #11820 which has more docs and actual tests, could we bump it for 0.14 ?

@NthTensor
Copy link
Contributor

There's an annoying and long-standing artifact issue with cones that we haven't quite sorted out yet. That's what's been blocking the other PR.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-Math Fundamental domain-agnostic mathematical operations X-Contentious There are nontrivial implications that should be thought through labels May 2, 2024
@alice-i-cecile
Copy link
Member

Closing in favor of #11820.

@alice-i-cecile alice-i-cecile added the S-Duplicate This issue or PR already exists label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen S-Duplicate This issue or PR already exists X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManevilleF @NthTensor @alice-i-cecile