fix remaining issues with background color in examples #14115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
C-Examples
alice-i-cecile
approved these changes
Jul 3, 2024
mockersf
added a commit
that referenced
this pull request
Jul 3, 2024
# Objective - Fixes #14097 ## Solution - Switching the uses of `UiImage` in examples to `BackgroundColor` when needed
ManevilleF
reviewed
Jul 3, 2024
There was a problem hiding this comment.
@mockersf @alice-i-cecile This seems incorrect, In those examples I used to tint the image color, not the square background color
ManevilleF
reviewed
Jul 3, 2024
rparrett
added a commit
to rparrett/bevy
that referenced
this pull request
Jul 3, 2024
…les (bevyengine#14115)" This partially reverts commit 160bcc7. Two examples: `ui_texture_slice` and `ui_texture_atlas_slice` were working as intended.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
…xamples. (#14121) # Objective Fixes #14120 `ui_texture_slice` and `ui_texture_atlas_slice` were working as intended, so undo the changes. ## Solution Partially revert #14115 for `ui_texture_slice` and `ui_texture_atlas_slice`. ## Testing Ran those two examples, confirmed the border color is the thing that changes when buttons are hovered.
mockersf
pushed a commit
that referenced
this pull request
Jul 3, 2024
…xamples. (#14121) # Objective Fixes #14120 `ui_texture_slice` and `ui_texture_atlas_slice` were working as intended, so undo the changes. ## Solution Partially revert #14115 for `ui_texture_slice` and `ui_texture_atlas_slice`. ## Testing Ran those two examples, confirmed the border color is the thing that changes when buttons are hovered.
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
) # Objective - Fixes bevyengine#14097 ## Solution - Switching the uses of `UiImage` in examples to `BackgroundColor` when needed
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
…xamples. (bevyengine#14121) # Objective Fixes bevyengine#14120 `ui_texture_slice` and `ui_texture_atlas_slice` were working as intended, so undo the changes. ## Solution Partially revert bevyengine#14115 for `ui_texture_slice` and `ui_texture_atlas_slice`. ## Testing Ran those two examples, confirmed the border color is the thing that changes when buttons are hovered.
MrGVSV
pushed a commit
to MrGVSV/bevy
that referenced
this pull request
Jul 5, 2024
) # Objective - Fixes bevyengine#14097 ## Solution - Switching the uses of `UiImage` in examples to `BackgroundColor` when needed
MrGVSV
pushed a commit
to MrGVSV/bevy
that referenced
this pull request
Jul 5, 2024
…xamples. (bevyengine#14121) # Objective Fixes bevyengine#14120 `ui_texture_slice` and `ui_texture_atlas_slice` were working as intended, so undo the changes. ## Solution Partially revert bevyengine#14115 for `ui_texture_slice` and `ui_texture_atlas_slice`. ## Testing Ran those two examples, confirmed the border color is the thing that changes when buttons are hovered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
UiImagein examples toBackgroundColorwhen needed