Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify ComputedNode #16134

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Constify ComputedNode #16134

merged 5 commits into from
Oct 29, 2024

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Oct 28, 2024 •
edited
Loading

Objective

Make all the methods and associated functions belonging to ComputedNode const.

Solution

Constify (except for inner_radius which uses non-const min and max).

@ickshonpe ickshonpe added C-Performance A change motivated by improving speed, memory usage or compile times A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 28, 2024
alice-i-cecile
alice-i-cecile approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of #16124.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 28, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 28, 2024
@cart cart added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@alice-i-cecile
Copy link
Member

@ickshonpe the fields have been renamed (by you!), so this needs to be redone for the latest main.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 29, 2024
Merged via the queue into bevyengine:main with commit dae39ac Oct 29, 2024
29 checks passed
mockersf pushed a commit that referenced this pull request Nov 5, 2024
@ickshonpe @alice-i-cecile @mockersf
Constify ComputedNode (#16134)
819ecc3 
# Objective

Make all the methods and associated functions belonging to
`ComputedNode` const.

## Solution

Constify (except for `inner_radius` which uses non-const `min` and
`max`).

---------

Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Performance A change motivated by improving speed, memory usage or compile times D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@ickshonpe @alice-i-cecile @cart @BenjaminBrienen