-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - add check for unused dependencies #2461
Conversation
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev | ||
|
||
- name: Run cargo udeps | ||
run: cargo udeps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the last run of this job: To find dependencies that are not used by any target, enable '--all-targets'.
Since Bevy supports quite a few different targets, how about adding --all-targets
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Targets here means build targets (tests, examples, ...) not target triples. Using --all-targets
would prevent detecting when regular dependencies could be dev-dependencies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a wonderful addition 😄
bors r+ |
# Objective - Unused dependencies are bad ## Solution - Add check for unused dependencies with https://github.com/est31/cargo-udeps - #2455
# Objective - Unused dependencies are bad ## Solution - Add check for unused dependencies with https://github.com/est31/cargo-udeps - bevyengine#2455
Objective
Solution