Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix the new nightly CI errors #2811

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix the new nightly CI errors #2811

wants to merge 2 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 12, 2021

Objective

Solution

  • Fix the errors which result from this by using the given fields
  • I also removed the now unused Debug impl.

I suspect that we shouldn't use -D warnings for nightly CI - ideally we'd get a discord webhook message into some (non-#github) dedicated channel on warnings.

But this does not implement that.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Sep 12, 2021
@DJMcNab DJMcNab added A-ECS Entities, components, systems, and events A-Meta About the project itself C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps P-High This is particularly urgent, and deserves immediate attention and removed S-Needs-Triage This issue needs to be labelled C-Testing A change that impacts how we test Bevy or how users test their apps labels Sep 12, 2021
IceSentry
IceSentry approved these changes Sep 12, 2021
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue, but I feel like this is a false positive on clippy side. The field was used here.

@MinerSebas MinerSebas mentioned this pull request Sep 12, 2021
Closed
@cart
Copy link
Member

cart commented Sep 12, 2021

Relevant: rust-lang/rust#88900

@cart
Copy link
Member

cart commented Sep 12, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 12, 2021
@DJMcNab
Fix the new nightly CI errors (#2811)
e74f7a7 
# Objective

- CI is failing again
- These failures result from rust-lang/rust#85200

## Solution

- Fix the errors which result from this by using the given fields
- I also removed the now unused `Debug` impl.

I suspect that we shouldn't use -D warnings for nightly CI - ideally we'd get a discord webhook message into some (non-#github) dedicated channel on warnings. 

But this does not implement that.
@bors
Copy link
Contributor

bors bot commented Sep 12, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix the new nightly CI errors [Merged by Bors] - Fix the new nightly CI errors Sep 12, 2021
@bors bors bot closed this Sep 12, 2021
@DJMcNab DJMcNab deleted the nightly_ci branch September 13, 2021 06:31
@matklad matklad mentioned this pull request Sep 15, 2021
Closed
@MinerSebas MinerSebas mentioned this pull request Sep 17, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerSebas MinerSebas MinerSebas approved these changes

@Weibye Weibye Weibye approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Meta About the project itself C-Examples An addition or correction to our examples P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DJMcNab @cart @IceSentry @Weibye @MinerSebas