[Merged by Bors] - StorageType parameter removed from ComponentDescriptor::new_resource #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Dec 30, 2021
crates/bevy_ecs/src/component.rs
Outdated
| Self { | ||
| name: std::any::type_name::<T>().to_string(), | ||
| storage_type, | ||
| // NOTE: `SparseStorage` may actually be a more | ||
| // resonable choice as `storage_type` for resources. |
alice-i-cecile
added
A-ECS
|
Looks good! Thanks for tackling this. Just a tiny nit then I think this can be merged. |
Co-authored-by: Alice Cecile <[email protected]>
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Dec 30, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 30, 2021
…3495) # Objective Remove the `StorageType` parameter from `ComponentDescriptor::new_resource` as discussed in #3361. - fixes #3361 ## Solution - Parameter removed. - Basic docs added. ## Note Left a [comment](#3361 (comment)) about `SparseStorage` being the more reasonable choice. Co-authored-by: r4gus <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
mockersf
pushed a commit
to mockersf/bevy
that referenced
this pull request
Jan 1, 2022
…evyengine#3495) # Objective Remove the `StorageType` parameter from `ComponentDescriptor::new_resource` as discussed in bevyengine#3361. - fixes bevyengine#3361 ## Solution - Parameter removed. - Basic docs added. ## Note Left a [comment](bevyengine#3361 (comment)) about `SparseStorage` being the more reasonable choice. Co-authored-by: r4gus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remove the
StorageTypeparameter fromComponentDescriptor::new_resourceas discussed in #3361.Solution
Note
Left a comment about
SparseStoragebeing the more reasonable choice.