[Merged by Bors] - Derive FromReflect for Transform and GlobalTransform
#6015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
approved these changes
Sep 18, 2022
MrGVSV
added
C-Usability
tim-blackbird
approved these changes
Sep 19, 2022
rparrett
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
# Objective Both components already derives `Reflect` and it would be nice to have `FromReflect` in order to ser/de between those types without relaying on `downcast`, since it can fail between different platforms, like WebAssembly. ## Solution Derive `FromReflect` for `Transform` and `GlobalTransform`. I thought if I should also derive `FromReflect` for `GlobalTransform`, since it's a computed component, but there may be some use cases where a `GlobalTransform` is needed to be sent over the wire, so I decided to do it.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
FromReflect for Transform and GlobalTransformFromReflect for Transform and GlobalTransform
vabrador
pushed a commit
to vabrador/bevy
that referenced
this pull request
Sep 27, 2022
…e#6015) Both components already derives `Reflect` and it would be nice to have `FromReflect` in order to ser/de between those types without relaying on `downcast`, since it can fail between different platforms, like WebAssembly. Derive `FromReflect` for `Transform` and `GlobalTransform`. I thought if I should also derive `FromReflect` for `GlobalTransform`, since it's a computed component, but there may be some use cases where a `GlobalTransform` is needed to be sent over the wire, so I decided to do it.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…e#6015) # Objective Both components already derives `Reflect` and it would be nice to have `FromReflect` in order to ser/de between those types without relaying on `downcast`, since it can fail between different platforms, like WebAssembly. ## Solution Derive `FromReflect` for `Transform` and `GlobalTransform`. I thought if I should also derive `FromReflect` for `GlobalTransform`, since it's a computed component, but there may be some use cases where a `GlobalTransform` is needed to be sent over the wire, so I decided to do it.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…e#6015) # Objective Both components already derives `Reflect` and it would be nice to have `FromReflect` in order to ser/de between those types without relaying on `downcast`, since it can fail between different platforms, like WebAssembly. ## Solution Derive `FromReflect` for `Transform` and `GlobalTransform`. I thought if I should also derive `FromReflect` for `GlobalTransform`, since it's a computed component, but there may be some use cases where a `GlobalTransform` is needed to be sent over the wire, so I decided to do it.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…e#6015) # Objective Both components already derives `Reflect` and it would be nice to have `FromReflect` in order to ser/de between those types without relaying on `downcast`, since it can fail between different platforms, like WebAssembly. ## Solution Derive `FromReflect` for `Transform` and `GlobalTransform`. I thought if I should also derive `FromReflect` for `GlobalTransform`, since it's a computed component, but there may be some use cases where a `GlobalTransform` is needed to be sent over the wire, so I decided to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Both components already derives
Reflectand it would be nice to haveFromReflectin order to ser/de between those types without relaying ondowncast, since it can fail between different platforms, like WebAssembly.Solution
Derive
FromReflectforTransformandGlobalTransform.I thought if I should also derive
FromReflectforGlobalTransform, since it's a computed component, but there may be some use cases where aGlobalTransformis needed to be sent over the wire, so I decided to do it.