Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Adapt path type of dynamically_load_plugin #6734

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Adapt path type of dynamically_load_plugin #6734

wants to merge 1 commit into from

Conversation

polygon
Copy link
Contributor

@polygon polygon commented Nov 22, 2022

Objective

Solution

  • Change the path function parameter of dynamically_load_plugin and DynamicPluginExt::load_plugin to a generic with AsRef<OsStr> bound

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-App Bevy apps and plugins labels Nov 22, 2022
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 4, 2022
@cart
Copy link
Member

cart commented Dec 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 5, 2022
@polygon
Adapt path type of dynamically_load_plugin (#6734)
9f0c41f 
# Objective

- Fixes #6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
@bors
Copy link
Contributor

bors bot commented Dec 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Adapt path type of dynamically_load_plugin [Merged by Bors] - Adapt path type of dynamically_load_plugin Dec 5, 2022
@bors bors bot closed this Dec 5, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 6, 2022
ickshonpe pushed a commit to ickshonpe/bevy that referenced this pull request Dec 6, 2022
@polygon @ickshonpe
Adapt path type of dynamically_load_plugin (bevyengine#6734)
14b4d3f 
# Objective

- Fixes bevyengine#6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@polygon @alradish
Adapt path type of dynamically_load_plugin (bevyengine#6734)
b4f5735 
# Objective

- Fixes bevyengine#6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@polygon @ItsDoot
Adapt path type of dynamically_load_plugin (bevyengine#6734)
7919ca3 
# Objective

- Fixes bevyengine#6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

dynamically_load_plugin should take an OsStr-like argument, not a &str
5 participants
@polygon @cart @james7132 @alice-i-cecile @tim-blackbird