-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Convenience method for entity naming #7186
Closed
Closed
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0904967
Debug name for entities
Aceeri 8278ab1
Add to prelude
Aceeri d205e1e
Better docs
Aceeri df94739
Refactor into worldquery
Aceeri 8e29254
Print entity with the name
Aceeri d81d8cc
Doctest for DebugName
Aceeri aaa5677
formatting
Aceeri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
use bevy_ecs::{component::Component, reflect::ReflectComponent}; | ||
use bevy_ecs::{ | ||
component::Component, entity::Entity, query::WorldQuery, reflect::ReflectComponent, | ||
}; | ||
use bevy_reflect::Reflect; | ||
use bevy_reflect::{std_traits::ReflectDefault, FromReflect}; | ||
use bevy_utils::AHasher; | ||
|
@@ -76,6 +78,25 @@ impl std::fmt::Display for Name { | |
} | ||
} | ||
|
||
/// Convenient query for giving a human friendly name to an entity. | ||
#[derive(WorldQuery)] | ||
pub struct DebugName { | ||
/// A [`Name`] that the entity might have that is displayed if available. | ||
pub name: Option<&'static Name>, | ||
/// The unique identifier of the entity as a fallback. | ||
pub entity: Entity, | ||
} | ||
|
||
impl std::fmt::Debug for DebugName { | ||
#[inline(always)] | ||
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { | ||
match self.name { | ||
Some(name) => std::fmt::Debug::fmt(&name, f), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe it would be worth printing out the |
||
None => std::fmt::Debug::fmt(&self.entity, f), | ||
} | ||
} | ||
} | ||
|
||
/* Conversions from strings */ | ||
|
||
impl From<&str> for Name { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a
no_run
doc test here to demonstrate how this is used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually helped me catch that I implemented Debug on DebugName instead of DebugNameItem, should we keep it no_run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's fine to let it run.