Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make ktx2 and zstd default features #7696

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Make ktx2 and zstd default features #7696

wants to merge 3 commits into from

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Feb 16, 2023 •
edited
Loading

Objective

  • Environment maps use these formats, and in the future rendering LUTs will need textures loaded by default in the engine

Solution

  • Make ktx2 and zstd part of the default feature
  • Let examples assume these features are enabled

Changelog

  • ktx2 and zstd are now part of bevy's default enabled features

Migration Guide

  • If you used the ktx2 or zstd features, you no longer need to explicitly enable them, as they are now part of bevy's default enabled features

@JMS55 JMS55 added the C-Dependencies A change to the crates that Bevy depends on label Feb 16, 2023
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-Assets Load files from disk to use for things like images, models, and sounds labels Feb 16, 2023
@alice-i-cecile
Copy link
Member

@JMS55 should this be in the release milestone?

@JMS55
Copy link
Contributor Author

JMS55 commented Feb 16, 2023

Probably. I'll add both this and the tonemapping PR to the milestone. Unsure why the CI is failing for this, though...

@JMS55 JMS55 added this to the 0.10 milestone Feb 16, 2023
@mockersf
Copy link
Member

mockersf commented Feb 16, 2023 •
edited
Loading

There is a test (test_supported_file_extensions) checking that all declared supported extensions are supported by the Image crate... which isn't the case for ktx2. I would be OK with that test being removed, it doesn't have enough value to start adding special cases to it...

alice-i-cecile
alice-i-cecile approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 17, 2023
bors bot pushed a commit that referenced this pull request Feb 17, 2023
@JMS55
Make ktx2 and zstd default features (#7696)
db2fd92 
# Objective
- Environment maps use these formats, and in the future rendering LUTs will need textures loaded by default in the engine

## Solution

- Make ktx2 and zstd part of the default feature
- Let examples assume these features are enabled

---

## Changelog
- `ktx2` and `zstd` are now party of bevy's default enabled features

## Migration Guide

- If you used the `ktx2` or `zstd` features, you no longer need to explicitly enable them, as they are now part of bevy's default enabled features
@bors
Copy link
Contributor

bors bot commented Feb 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make ktx2 and zstd default features [Merged by Bors] - Make ktx2 and zstd default features Feb 17, 2023
@bors bors bot closed this Feb 17, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 18, 2023
@JMS55 @myreprise1
Make ktx2 and zstd default features (bevyengine#7696)
a91f236 
- Environment maps use these formats, and in the future rendering LUTs will need textures loaded by default in the engine

- Make ktx2 and zstd part of the default feature
- Let examples assume these features are enabled

---

- `ktx2` and `zstd` are now party of bevy's default enabled features

- If you used the `ktx2` or `zstd` features, you no longer need to explicitly enable them, as they are now part of bevy's default enabled features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@JMS55 @alice-i-cecile @mockersf