Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove a duplicate lookup in apply_state_transitions #7800

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove a duplicate lookup in apply_state_transitions #7800

wants to merge 1 commit into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Feb 24, 2023

Objective

Remove a duplicate resource lookup and an unnecessary panic.

@JoJoJet JoJoJet added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times labels Feb 24, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 24, 2023
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 24, 2023
@JoJoJet
Remove a duplicate lookup in apply_state_transitions (#7800)
e27e04a 
# Objective

Remove a duplicate resource lookup and an unnecessary panic.
@bors
Copy link
Contributor

bors bot commented Feb 24, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove a duplicate lookup in apply_state_transitions [Merged by Bors] - Remove a duplicate lookup in apply_state_transitions Feb 24, 2023
@bors bors bot closed this Feb 24, 2023
@JoJoJet JoJoJet deleted the cleanup-transitions branch February 24, 2023 11:55
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@JoJoJet @Shfty
Remove a duplicate lookup in apply_state_transitions (bevyengine#7800)
b51e584 
# Objective

Remove a duplicate resource lookup and an unnecessary panic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoJoJet @mockersf @james7132 @alice-i-cecile @tim-blackbird