[Merged by Bors] - Fix bevy_ui compile error without bevy_text
#7877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Mar 2, 2023
|
Ping @ndarilek for review if you're able. |
alice-i-cecile
added
C-Bug
|
Thanks for the ping. LGTM--not sure how or if I can approve a PR but I certainly do this one. :) |
|
You can under the tab "Files changed" and then the "Review changes" button offers the option to Approve, Request Changes or just leave Comments :) |
ndarilek
approved these changes
Mar 2, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
# Objective - Fixes #7874. - The `bevy_text` dependency is optional for `bevy_ui`, but the `accessibility` module depended on it. ## Solution - Guard the `accessibility` module behind the `bevy_text` feature and only add the plugin when it's enabled.
bors
bot
changed the title
bevy_ui compile error without bevy_textbevy_ui compile error without bevy_text
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
# Objective - Fixes bevyengine#7874. - The `bevy_text` dependency is optional for `bevy_ui`, but the `accessibility` module depended on it. ## Solution - Guard the `accessibility` module behind the `bevy_text` feature and only add the plugin when it's enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_ui#7874.bevy_textdependency is optional forbevy_ui, but theaccessibilitymodule depended on it.Solution
accessibilitymodule behind thebevy_textfeature and only add the plugin when it's enabled.