-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integer equivalents for Rect
#7984
Merged
alice-i-cecile
merged 21 commits into
bevyengine:main
from
LiamGallagher737:integer-rects
Jun 12, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a2c4731
`create_rect_type` macro, no docs
LiamGallagher737 9439952
Method docs
LiamGallagher737 7899852
Add `IRect` and `URect`
LiamGallagher737 af87270
pass ci
LiamGallagher737 a19968e
Custom assert message for `URect` overflow
LiamGallagher737 b001f5b
Better asset messages
LiamGallagher737 6d2abd3
cargo fmt
LiamGallagher737 850c9f6
rounding comment + better assert messages
LiamGallagher737 e34428d
Merge branch 'bevyengine:main' into integer-rects
LiamGallagher737 d61d00c
More rounding comments and `outset` for `URect`
LiamGallagher737 9a2c392
fmt
LiamGallagher737 007cd93
Make `URect` `inset` take `i32`, remove `outset`, `add examples for n…
LiamGallagher737 ba87c38
fmt, again
LiamGallagher737 063b384
code review
LiamGallagher737 747cafd
more rounding notes
LiamGallagher737 363263c
URect inset without conversion
LiamGallagher737 8f05a6f
forgot fmt again
LiamGallagher737 f3c3aed
Methods for convert between rect types
LiamGallagher737 fb56d15
Use glams as_* methods for rect conversions
LiamGallagher737 f9fb051
Saturte insted of panic for URect inset
LiamGallagher737 1557557
remove incorrect panic docs
LiamGallagher737 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good idea 👍