Make bevy_render an optional dependency of bevy_scene #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Mar 20, 2023
tim-blackbird
approved these changes
Mar 20, 2023
james7132
requested changes
Mar 20, 2023
james7132
approved these changes
Mar 20, 2023
|
this doesn't makes it possible to enable the |
|
@mockersf I've made it so that bevy_scene/bevy_render only gets enabled when bevy_render was enabled. |
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 30, 2023
|
@Neo-Zhixing there's just a small conflict, once you resolved it we can merge! |
Estus-Dev
pushed a commit
to Estus-Dev/bevy
that referenced
this pull request
Jul 10, 2023
# Objective bevy-scene does not have a reason to depend on bevy-render except to include the `Visibility` and `ComputedVisibility` components. Including that in the dependency chain is unnecessary for people not using `bevy_render`. Also fixed a problem where compilation fails when the `serialize` feature was not enabled. ## Solution This was added in bevyengine#5335 to address some of the problems caused by bevyengine#5310. Imo the user just always have to remember to include `VisibilityBundle` when they spawn `SceneBundle` or `DynamicSceneBundle`, but that will be a breaking change. This PR makes `bevy_render` an optional dependency of `bevy_scene` instead to respect the existing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy-scene does not have a reason to depend on bevy-render except to include the
VisibilityandComputedVisibilitycomponents. Including that in the dependency chain is unnecessary for people not usingbevy_render.Also fixed a problem where compilation fails when the
serializefeature was not enabled.Solution
This was added in #5335 to address some of the problems caused by #5310.
Imo the user just always have to remember to include
VisibilityBundlewhen they spawnSceneBundleorDynamicSceneBundle, but that will be a breaking change. This PR makesbevy_renderan optional dependency ofbevy_sceneinstead to respect the existing behavior.